Add --glob and --regex #96
Conversation
src/main.rs
Outdated
| } else { | ||
| match GlobBuilder::new(pattern).literal_separator(true).build() { | ||
| Ok(glob) => { | ||
| // TODO: provide an option to remove (?-u) in the upstream? |
There was a problem hiding this comment.
If it is unnecessary to match arbitrary bytes in the path, then no need to remove (?-u).
src/main.rs
Outdated
| match GlobBuilder::new(pattern).literal_separator(true).build() { | ||
| Ok(glob) => { | ||
| // TODO: provide an option to remove (?-u) in the upstream? | ||
| eprintln!("GLOB:{} | REGEX: {}", glob.glob(), glob.regex()); |
There was a problem hiding this comment.
Yes, just to get you familiar with how --glob works.
|
Added tests for --full-path and rebased. |
|
Another problem is how to apply (maybe not a problem) |
I think we should do the same as for #111. |
|
Yes, and no option to disable "dot-all" for glob patterns? I'm ok with this. |
Me too. |
|
I've added some todos in the top comment. |
Closes #97
|
Closing. I plan to do this in my private fork. Thanks for making |
WIP:
[ ] update the "globset" crate in the upstream?--full-pathping #85